Forge + Fabric Opaque Particles for Shader Compat #4525
Conversation
…d FXWisp/Spark to render without transparency for shader compatibility (with GLSL deferred shading)
Fabric/src/main/java/vazkii/botania/fabric/FiberBotaniaConfig.java
Outdated
Show resolved
Hide resolved
|
Should be resolved |
|
did you push your changes? The comments I left still seem relevant on the latest version of your PR |
|
Sorry, baby's first git bash :) |
|
Supplemental info- intended to fix #4297 , btw- my comment there is similarly relevant; disabling botania's shaders decrease aesthetic detail, but increase compatibility with certain shaders. This fork is intended to extend that concept to include OpenGL deferred shaders as well
Note: This screenshot was made while the config settings for shader compat and particle compat were combined, but in the current build they are separate options, as noted above |
|
There will probably be a bunch of shader-/rendering-related changes in the 1.21 port. This PR seems worth revisiting as part of that. |
artemisSystem
added
the
after-1.21-port
When a shader pack uses GLSL deferred rendering, particles with transparency are not rendered correctly.
This addition to the config file will change the rendering method when opaqueParticles is set to true in the config, so particles render opaquely (albeit not quite as pretty as they render as is, with shaders they would not have rendered at all, so I feel this change is beneficial but not perfect)